-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin download & locking #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
traut
approved these changes
Mar 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Andrew-Morozko
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a couple of nitpicks from me, not blockers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements:
Download and install missing plugins #3
Added new command
fabric install
which install plugins into{{cacheDir}}/plugins
and creates.fabric-lock.json
file containing locks for plugins on all platforms.Use
--upgrade
or-u
flag withfabric install
to download missing or updated plugins in version constraint list under global configuration.Global config has new property
fabric.plugin_registry.base_url
(default:https://registry.blackstork.io
)Removed
--plugin-dir
flag because it could cause issues. It's best to use global config parameterfabric.plugin_registrty.mirror_dir
instead since it ensures this property stays the same when running differentinstall
,render
,data
commands in sequence.These changes also include updated
.goreleaser.yaml
andtools/pluginmeta
script to bundle each plugin into separate archive and make release parsable for Fabric Registry.