Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin download & locking #118

Merged
merged 12 commits into from
Mar 5, 2024
Merged

Plugin download & locking #118

merged 12 commits into from
Mar 5, 2024

Conversation

dobarx
Copy link
Contributor

@dobarx dobarx commented Mar 3, 2024

Implements:

  • Download and install missing plugins #3

  • Added new command fabric install which install plugins into {{cacheDir}}/plugins and creates .fabric-lock.json file containing locks for plugins on all platforms.

    Use --upgrade or -u flag with fabric install to download missing or updated plugins in version constraint list under global configuration.

  • Global config has new property fabric.plugin_registry.base_url (default: https://registry.blackstork.io)

     fabric {
        plugin_registry {
           base_url = "https://registry.blackstork.io"
        }
     }
  • Removed --plugin-dir flag because it could cause issues. It's best to use global config parameter fabric.plugin_registrty.mirror_dir instead since it ensures this property stays the same when running different install, render, data commands in sequence.

  • These changes also include updated .goreleaser.yaml and tools/pluginmeta script to bundle each plugin into separate archive and make release parsable for Fabric Registry.

Copy link
Member

@traut traut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Contributor

@Andrew-Morozko Andrew-Morozko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a couple of nitpicks from me, not blockers

cmd/install.go Outdated Show resolved Hide resolved
plugin/resolver/source_remote.go Outdated Show resolved Hide resolved
@dobarx dobarx merged commit 930c21b into main Mar 5, 2024
5 checks passed
@dobarx dobarx deleted the plugins branch March 5, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants